diff options
author | Kees Cook <keescook@chromium.org> | 2023-03-02 14:49:50 -0800 |
---|---|---|
committer | Kees Cook <keescook@chromium.org> | 2023-03-24 20:10:59 -0700 |
commit | b69edab47f1da8edd8e7bfdf8c70f51a2a5d89fb (patch) | |
tree | b39ab4b864477aec0eb1eef571e3c04f51e3a4d3 /fs/openpromfs | |
parent | eeac8ede17557680855031c6f305ece2378af326 (diff) |
kheaders: Use array declaration instead of char
Under CONFIG_FORTIFY_SOURCE, memcpy() will check the size of destination
and source buffers. Defining kernel_headers_data as "char" would trip
this check. Since these addresses are treated as byte arrays, define
them as arrays (as done everywhere else).
This was seen with:
$ cat /sys/kernel/kheaders.tar.xz >> /dev/null
detected buffer overflow in memcpy
kernel BUG at lib/string_helpers.c:1027!
...
RIP: 0010:fortify_panic+0xf/0x20
[...]
Call Trace:
<TASK>
ikheaders_read+0x45/0x50 [kheaders]
kernfs_fop_read_iter+0x1a4/0x2f0
...
Reported-by: Jakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/bpf/20230302112130.6e402a98@kernel.org/
Acked-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Tested-by: Jakub Kicinski <kuba@kernel.org>
Fixes: 43d8ce9d65a5 ("Provide in-kernel headers to make extending kernel easier")
Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230302224946.never.243-kees@kernel.org
Diffstat (limited to 'fs/openpromfs')
0 files changed, 0 insertions, 0 deletions