summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorAmir Goldstein <amir73il@gmail.com>2024-09-04 10:46:57 +0200
committerTheodore Ts'o <tytso@mit.edu>2024-11-12 23:54:13 -0500
commit150c174a6053efc215b7a10b7fbcc869039bb6c3 (patch)
treeaaedc7633b113d819a17bdda842ed80e8307758a /fs
parenta9cdf82a47addae72b119a063fc834923e7838fe (diff)
ext4: return error on syncfs after shutdown
This is the logic behavior and one that we would like to verify using a generic fstest similar to xfs/546. Link: https://lore.kernel.org/fstests/20240830152648.GE6216@frogsfrogsfrogs/ Suggested-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Amir Goldstein <amir73il@gmail.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://patch.msgid.link/20240904084657.1062243-1-amir73il@gmail.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs')
-rw-r--r--fs/ext4/super.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index e7d3c2e209ba..e4bdb896e202 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -6304,7 +6304,7 @@ static int ext4_sync_fs(struct super_block *sb, int wait)
struct ext4_sb_info *sbi = EXT4_SB(sb);
if (unlikely(ext4_forced_shutdown(sb)))
- return 0;
+ return -EIO;
trace_ext4_sync_fs(sb, wait);
flush_workqueue(sbi->rsv_conversion_wq);