diff options
| author | Robin Murphy <robin.murphy@arm.com> | 2017-07-24 18:29:27 +0100 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2017-08-25 16:56:13 +0200 |
| commit | 5237e95f63761477b7ea45499d08b89383a77eab (patch) | |
| tree | c36af924cea82bb94babb220f7adf1c8f9a75956 /include/linux/dma-mapping.h | |
| parent | ee7b1f31200d9f3cc45e1bd22e962bd6b1d4d611 (diff) | |
dma-mapping: reduce dma_mapping_error inline bloat
Thanks to the nested inlining, all drivers correctly calling
dma_mapping_error() after a mapping a page or single buffer generate two
calls to get_arch_dma_ops() per callsite, which all adds up to a fair
old chunk of useless code, e.g. ~3KB for an arm64 defconfig plus extras:
text data bss dec hex filename
13051391 1503898 327768 14883057 e318f1 vmlinux.o.old
13050751 1503898 327768 14882417 e31671 vmlinux.o.new
Give the compiler a hand by making it clear we want the same ops.
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'include/linux/dma-mapping.h')
| -rw-r--r-- | include/linux/dma-mapping.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index 03c0196a6f24..66d8ea68f40b 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -565,10 +565,11 @@ static inline void dma_free_noncoherent(struct device *dev, size_t size, static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr) { - debug_dma_mapping_error(dev, dma_addr); + const struct dma_map_ops *ops = get_dma_ops(dev); - if (get_dma_ops(dev)->mapping_error) - return get_dma_ops(dev)->mapping_error(dev, dma_addr); + debug_dma_mapping_error(dev, dma_addr); + if (ops->mapping_error) + return ops->mapping_error(dev, dma_addr); return 0; } |