summaryrefslogtreecommitdiff
path: root/include/linux/minmax.h
diff options
context:
space:
mode:
authorDavid Laight <David.Laight@ACULAB.COM>2023-09-18 08:18:40 +0000
committerAndrew Morton <akpm@linux-foundation.org>2023-10-18 14:43:22 -0700
commit4ead534fba42fc4fd41163297528d2aa731cd121 (patch)
treed2bab70001ffd173f3a83d4301526a4aaedc79f5 /include/linux/minmax.h
parentf4b84b2ff851f01d0fac619eadef47eb41648534 (diff)
minmax: allow comparisons of 'int' against 'unsigned char/short'
Since 'unsigned char/short' get promoted to 'signed int' it is safe to compare them against an 'int' value. Link: https://lkml.kernel.org/r/8732ef5f809c47c28a7be47c938b28d4@AcuMS.aculab.com Signed-off-by: David Laight <david.laight@aculab.com> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Christoph Hellwig <hch@infradead.org> Cc: Jason A. Donenfeld <Jason@zx2c4.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Matthew Wilcox (Oracle) <willy@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'include/linux/minmax.h')
-rw-r--r--include/linux/minmax.h5
1 files changed, 3 insertions, 2 deletions
diff --git a/include/linux/minmax.h b/include/linux/minmax.h
index c0e738eacefa..842c1db62ffe 100644
--- a/include/linux/minmax.h
+++ b/include/linux/minmax.h
@@ -26,8 +26,9 @@
__builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))), \
is_signed_type(typeof(x)), 0)
-#define __types_ok(x, y) \
- (__is_signed(x) == __is_signed(y))
+#define __types_ok(x, y) \
+ (__is_signed(x) == __is_signed(y) || \
+ __is_signed((x) + 0) == __is_signed((y) + 0))
#define __cmp_op_min <
#define __cmp_op_max >