diff options
| author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2019-06-13 10:55:31 +0900 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2019-06-25 10:49:18 +0200 |
| commit | ec6516bfbaf72e7c81811162b6de96322e32a027 (patch) | |
| tree | b09f9ad73cc42c90e6c43504381b69751182abdd /include/linux/pinctrl/pinmux.h | |
| parent | d9c238c5a6aeee2706d5ace0b1aa005e6d1a482f (diff) | |
pinctrl: remove unneeded #ifdef around declarations
What is the point in surrounding the whole of declarations with
ifdef like this?
#ifdef CONFIG_FOO
int foo(void);
#endif
If CONFIG_FOO is not defined, all callers of foo() will fail
with implicit declaration errors since the top Makefile adds
-Werror-implicit-function-declaration to KBUILD_CFLAGS.
This breaks the build earlier when you are doing something wrong.
That's it.
Anyway, it will fail to link since the definition of foo() is not
compiled.
In summary, these ifdef are unneeded.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'include/linux/pinctrl/pinmux.h')
| -rw-r--r-- | include/linux/pinctrl/pinmux.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/include/linux/pinctrl/pinmux.h b/include/linux/pinctrl/pinmux.h index ace60d775b20..566a5fe8eab5 100644 --- a/include/linux/pinctrl/pinmux.h +++ b/include/linux/pinctrl/pinmux.h @@ -16,8 +16,6 @@ #include <linux/seq_file.h> #include <linux/pinctrl/pinctrl.h> -#ifdef CONFIG_PINMUX - struct pinctrl_dev; /** @@ -85,6 +83,4 @@ struct pinmux_ops { bool strict; }; -#endif /* CONFIG_PINMUX */ - #endif /* __LINUX_PINCTRL_PINMUX_H */ |