summaryrefslogtreecommitdiff
path: root/include/linux/wmi.h
diff options
context:
space:
mode:
authorDarren Hart (VMware) <dvhart@infradead.org>2017-05-19 19:28:36 -0700
committerDarren Hart (VMware) <dvhart@infradead.org>2017-06-06 10:15:20 -0700
commitfd70da6a6267c91fbdda9c560f098cfd52fba00f (patch)
tree378c9c14573ce622164b455e5fb48c4a80b5cbea /include/linux/wmi.h
parentf63019861cd1192e546397b13f926876a93450fd (diff)
platform/x86: wmi: Require query for data blocks, rename writable to setable
The Microsoft WMI documentation requires all data blocks to implement the Query Control Method (WQxx). If we encounter a data block not implementing this control method, issue a warning, and ignore the data block. Remove the "readable" attribute as all data blocks must be readable (query-able). Be consistent with the language in the documentation, replace the "writable" attribute with "setable". Simplify (flatten) the control flow of wmi_create_device a bit while we are updating it for the above changes. Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Mario Limonciello <mario_limonciello@dell.com> Cc: Pali Rohár <pali.rohar@gmail.com> Cc: linux-kernel@vger.kernel.org Cc: platform-driver-x86@vger.kernel.org Cc: linux-acpi@vger.kernel.org Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'include/linux/wmi.h')
-rw-r--r--include/linux/wmi.h7
1 files changed, 2 insertions, 5 deletions
diff --git a/include/linux/wmi.h b/include/linux/wmi.h
index a283768afb7e..cd0d7734dc49 100644
--- a/include/linux/wmi.h
+++ b/include/linux/wmi.h
@@ -22,11 +22,8 @@
struct wmi_device {
struct device dev;
- /*
- * These are true for data objects that support reads and writes,
- * respectively.
- */
- bool readable, writeable;
+ /* True for data blocks implementing the Set Control Method */
+ bool setable;
};
/* Caller must kfree the result. */