summaryrefslogtreecommitdiff
path: root/include/net/request_sock.h
diff options
context:
space:
mode:
authorGuillaume Nault <gnault@redhat.com>2019-03-09 10:26:53 +0100
committerDavid S. Miller <davem@davemloft.net>2019-03-09 19:51:44 -0800
commit1039c6e1936ef2be0f342bd56fcf0fb25c1df5fe (patch)
tree957e9c90f4b705607037e7f49ab6478c8435f6c1 /include/net/request_sock.h
parent1f5d861f7fefa971b2c6e766f77932c86419a319 (diff)
net: keep refcount warning in reqsk_free()
As Eric Dumazet said, "We do not have a way to tell if the req was ever inserted in a hash table, so better play safe.". Let's remove this comment, so that nobody will be tempted to drop the WARN_ON_ONCE() line. Signed-off-by: Guillaume Nault <gnault@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/request_sock.h')
-rw-r--r--include/net/request_sock.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/include/net/request_sock.h b/include/net/request_sock.h
index 347015515a7d..21a5243fecd1 100644
--- a/include/net/request_sock.h
+++ b/include/net/request_sock.h
@@ -108,7 +108,6 @@ reqsk_alloc(const struct request_sock_ops *ops, struct sock *sk_listener,
static inline void reqsk_free(struct request_sock *req)
{
- /* temporary debugging */
WARN_ON_ONCE(refcount_read(&req->rsk_refcnt) != 0);
req->rsk_ops->destructor(req);