summaryrefslogtreecommitdiff
path: root/include/net
diff options
context:
space:
mode:
authorMoshe Shemesh <moshe@mellanox.com>2019-04-29 12:41:45 +0300
committerDavid S. Miller <davem@davemloft.net>2019-05-01 11:07:03 -0400
commitb587bdaf5f820cf7dac2c1b351db97bf98e1f427 (patch)
tree506edca56c4af13657e8f1136b5de7e9c4784960 /include/net
parent5be90f993880052d95bbf6ccdca3fa081eb9b1ff (diff)
devlink: Change devlink health locking mechanism
The devlink health reporters create/destroy and user commands currently use the devlink->lock as a locking mechanism. Different reporters have different rules in the driver and are being created/destroyed during different stages of driver load/unload/running. So during execution of a reporter recover the flow can go through another reporter's destroy and create. Such flow leads to deadlock trying to lock a mutex already held. With the new locking mechanism the different reporters share mutex lock only to protect access to shared reporters list. Added refcount per reporter, to protect the reporters from destroy while being used. Signed-off-by: Moshe Shemesh <moshe@mellanox.com> Signed-off-by: Jiri Pirko <jiri@mellanox.com> Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net')
-rw-r--r--include/net/devlink.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/include/net/devlink.h b/include/net/devlink.h
index 4f5e41613503..1c4adfb4195a 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -32,6 +32,7 @@ struct devlink {
struct list_head region_list;
u32 snapshot_id;
struct list_head reporter_list;
+ struct mutex reporters_lock; /* protects reporter_list */
struct devlink_dpipe_headers *dpipe_headers;
const struct devlink_ops *ops;
struct device *dev;