summaryrefslogtreecommitdiff
path: root/include/net
diff options
context:
space:
mode:
authorLouis Peens <louis.peens@corigine.com>2022-03-23 11:25:06 +0200
committerJakub Kicinski <kuba@kernel.org>2022-03-23 10:32:48 -0700
commit054d5575cd6ed2792611a7cbb8c88663cc873780 (patch)
tree1d12b5b94b59764454b678051f99d7631ed0dfbd /include/net
parenta911ad18a56aeecf87a098ad1cdc4de91d7f60de (diff)
net/sched: fix incorrect vlan_push_eth dest field
Seems like a potential copy-paste bug slipped in here, the second memcpy should of course be populating src and not dest. Fixes: ab95465cde23 ("net/sched: add vlan push_eth and pop_eth action to the hardware IR") Signed-off-by: Louis Peens <louis.peens@corigine.com> Link: https://lore.kernel.org/r/20220323092506.21639-1-louis.peens@corigine.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include/net')
-rw-r--r--include/net/tc_act/tc_vlan.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/tc_act/tc_vlan.h b/include/net/tc_act/tc_vlan.h
index a97600f742de..904eddfc1826 100644
--- a/include/net/tc_act/tc_vlan.h
+++ b/include/net/tc_act/tc_vlan.h
@@ -84,7 +84,7 @@ static inline void tcf_vlan_push_eth(unsigned char *src, unsigned char *dest,
{
rcu_read_lock();
memcpy(dest, rcu_dereference(to_vlan(a)->vlan_p)->tcfv_push_dst, ETH_ALEN);
- memcpy(dest, rcu_dereference(to_vlan(a)->vlan_p)->tcfv_push_src, ETH_ALEN);
+ memcpy(src, rcu_dereference(to_vlan(a)->vlan_p)->tcfv_push_src, ETH_ALEN);
rcu_read_unlock();
}