summaryrefslogtreecommitdiff
path: root/include/ufs
diff options
context:
space:
mode:
authorBart Van Assche <bvanassche@acm.org>2023-07-27 12:41:19 -0700
committerMartin K. Petersen <martin.petersen@oracle.com>2023-07-31 15:17:50 -0400
commit08108d31129a104b06628b3ac95af2af9f5e9e4c (patch)
tree44f0aa21931647e229caa01a821c3cfb6f33ce4d /include/ufs
parentf99533bd7e3dc033093f339784bebe0247e1831c (diff)
scsi: ufs: Improve type safety
Assign names to the enumeration types for UPIU types. Use these enumeration types where appropriate. Signed-off-by: Bart Van Assche <bvanassche@acm.org> Link: https://lore.kernel.org/r/20230727194457.3152309-8-bvanassche@acm.org Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'include/ufs')
-rw-r--r--include/ufs/ufs.h4
-rw-r--r--include/ufs/ufshcd.h6
2 files changed, 2 insertions, 8 deletions
diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h
index 0fb733683953..797bf033c19a 100644
--- a/include/ufs/ufs.h
+++ b/include/ufs/ufs.h
@@ -78,7 +78,7 @@ enum {
};
/* UTP UPIU Transaction Codes Initiator to Target */
-enum {
+enum upiu_request_transaction {
UPIU_TRANSACTION_NOP_OUT = 0x00,
UPIU_TRANSACTION_COMMAND = 0x01,
UPIU_TRANSACTION_DATA_OUT = 0x02,
@@ -87,7 +87,7 @@ enum {
};
/* UTP UPIU Transaction Codes Target to Initiator */
-enum {
+enum upiu_response_transaction {
UPIU_TRANSACTION_NOP_IN = 0x20,
UPIU_TRANSACTION_RESPONSE = 0x21,
UPIU_TRANSACTION_DATA_IN = 0x22,
diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
index 67bd089e70bc..2b1f4f2a4464 100644
--- a/include/ufs/ufshcd.h
+++ b/include/ufs/ufshcd.h
@@ -1357,12 +1357,6 @@ int ufshcd_get_vreg(struct device *dev, struct ufs_vreg *vreg);
int ufshcd_send_uic_cmd(struct ufs_hba *hba, struct uic_command *uic_cmd);
-int ufshcd_exec_raw_upiu_cmd(struct ufs_hba *hba,
- struct utp_upiu_req *req_upiu,
- struct utp_upiu_req *rsp_upiu,
- int msgcode,
- u8 *desc_buff, int *buff_len,
- enum query_opcode desc_op);
int ufshcd_advanced_rpmb_req_handler(struct ufs_hba *hba, struct utp_upiu_req *req_upiu,
struct utp_upiu_req *rsp_upiu, struct ufs_ehs *ehs_req,
struct ufs_ehs *ehs_rsp, int sg_cnt,