diff options
author | Huacai Chen <chenhuacai@loongson.cn> | 2022-11-21 19:02:57 +0800 |
---|---|---|
committer | Huacai Chen <chenhuacai@loongson.cn> | 2022-11-21 19:02:57 +0800 |
commit | bf2f34a506e66e2979de6b17c337c5d4b25b4d2c (patch) | |
tree | 1f3509616a3a1af413353d0b7bf5993aef8a1eda /include/xen/page.h | |
parent | e428e9613531d1ef6bd0d91352899712b29134fb (diff) |
LoongArch: Set _PAGE_DIRTY only if _PAGE_WRITE is set in {pmd,pte}_mkdirty()
Now {pmd,pte}_mkdirty() set _PAGE_DIRTY bit unconditionally, this causes
random segmentation fault after commit 0ccf7f168e17bb7e ("mm/thp: carry
over dirty bit when thp splits on pmd").
The reason is: when fork(), parent process use pmd_wrprotect() to clear
huge page's _PAGE_WRITE and _PAGE_DIRTY (for COW); then pte_mkdirty() set
_PAGE_DIRTY as well as _PAGE_MODIFIED while splitting dirty huge pages;
once _PAGE_DIRTY is set, there will be no tlb modify exception so the COW
machanism fails; and at last memory corruption occurred between parent
and child processes.
So, we should set _PAGE_DIRTY only when _PAGE_WRITE is set in {pmd,pte}_
mkdirty().
Cc: stable@vger.kernel.org
Cc: Peter Xu <peterx@redhat.com>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Diffstat (limited to 'include/xen/page.h')
0 files changed, 0 insertions, 0 deletions