diff options
| author | Andrey Konovalov <andreyknvl@google.com> | 2023-02-10 22:16:00 +0100 |
|---|---|---|
| committer | Andrew Morton <akpm@linux-foundation.org> | 2023-02-16 20:43:51 -0800 |
| commit | 514d5c557b8b590a80f0569af5ae5f4d455ecef2 (patch) | |
| tree | a4813263ac0742521e54e22d1520966a75317fff /kernel/kallsyms_selftest.h | |
| parent | cb788e84a4cfe47941cded45b5ca81a917fbb1a6 (diff) | |
lib/stacktrace: drop impossible WARN_ON for depot_init_pool
depot_init_pool has two call sites:
1. In depot_alloc_stack with a potentially NULL prealloc.
2. In __stack_depot_save with a non-NULL prealloc.
At the same time depot_init_pool can only return false when prealloc is
NULL.
As the second call site makes sure that prealloc is not NULL, the WARN_ON
there can never trigger. Thus, drop the WARN_ON and also move the prealloc
check from depot_init_pool to its first call site.
Also change the return type of depot_init_pool to void as it now always
returns true.
Link: https://lkml.kernel.org/r/ce149f9bdcbc80a92549b54da67eafb27f846b7b.1676063693.git.andreyknvl@google.com
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Reviewed-by: Alexander Potapenko <glider@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'kernel/kallsyms_selftest.h')
0 files changed, 0 insertions, 0 deletions