path: root/kernel/seccomp.c
diff options
authorSteven Rostedt (Red Hat) <>2016-11-07 16:26:37 -0500
committerSteven Rostedt (VMware) <>2019-04-05 09:26:43 -0400
commitb35f549df1d7520d37ba1e6d4a8d4df6bd52d136 (patch)
treeb7e544da953806a2f4d9b2d0aeb167d0baad3955 /kernel/seccomp.c
parented3bb007021b9bddb90afae28a19f08ed8890add (diff)
syscalls: Remove start and number from syscall_get_arguments() args
At Linux Plumbers, Andy Lutomirski approached me and pointed out that the function call syscall_get_arguments() implemented in x86 was horribly written and not optimized for the standard case of passing in 0 and 6 for the starting index and the number of system calls to get. When looking at all the users of this function, I discovered that all instances pass in only 0 and 6 for these arguments. Instead of having this function handle different cases that are never used, simply rewrite it to return the first 6 arguments of a system call. This should help out the performance of tracing system calls by ptrace, ftrace and perf. Link: Cc: Oleg Nesterov <> Cc: Kees Cook <> Cc: Andy Lutomirski <> Cc: Dominik Brodowski <> Cc: Dave Martin <> Cc: "Dmitry V. Levin" <> Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: Acked-by: Paul Burton <> # MIPS parts Acked-by: Max Filippov <> # For xtensa changes Acked-by: Will Deacon <> # For the arm64 bits Reviewed-by: Thomas Gleixner <> # for x86 Reviewed-by: Dmitry V. Levin <> Reported-by: Andy Lutomirski <> Signed-off-by: Steven Rostedt (VMware) <>
Diffstat (limited to 'kernel/seccomp.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/seccomp.c b/kernel/seccomp.c
index 54a0347ca812..df27e499956a 100644
--- a/kernel/seccomp.c
+++ b/kernel/seccomp.c
@@ -149,7 +149,7 @@ static void populate_seccomp_data(struct seccomp_data *sd)
sd->nr = syscall_get_nr(task, regs);
sd->arch = syscall_get_arch();
- syscall_get_arguments(task, regs, 0, 6, args);
+ syscall_get_arguments(task, regs, args);
sd->args[0] = args[0];
sd->args[1] = args[1];
sd->args[2] = args[2];