diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2022-12-14 18:01:00 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-12-16 10:21:36 +0000 |
| commit | b4cafb3d2c740f8d1b1234b43ac4a60e5291c960 (patch) | |
| tree | a3c1f428f48b09f7f79c5b426522e2b7d508f0f3 /lib/pm-notifier-error-inject.c | |
| parent | 32f1002ed4851d9eb28ea1aba58757bd4b66e63b (diff) | |
devlink: hold region lock when flushing snapshots
Netdevsim triggers a splat on reload, when it destroys regions
with snapshots pending:
WARNING: CPU: 1 PID: 787 at net/core/devlink.c:6291 devlink_region_snapshot_del+0x12e/0x140
CPU: 1 PID: 787 Comm: devlink Not tainted 6.1.0-07460-g7ae9888d6e1c #580
RIP: 0010:devlink_region_snapshot_del+0x12e/0x140
Call Trace:
<TASK>
devl_region_destroy+0x70/0x140
nsim_dev_reload_down+0x2f/0x60 [netdevsim]
devlink_reload+0x1f7/0x360
devlink_nl_cmd_reload+0x6ce/0x860
genl_family_rcv_msg_doit.isra.0+0x145/0x1c0
This is the locking assert in devlink_region_snapshot_del(),
we're supposed to be holding the region->snapshot_lock here.
Fixes: 2dec18ad826f ("net: devlink: remove region snapshots list dependency on devlink->lock")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib/pm-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions