summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2019-05-07 11:36:34 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-05-24 20:40:10 +0200
commit110080cea0d0e4dfdb0b536e7f8a5633ead6a781 (patch)
tree175c7135a67aeec7d97deae544bb373b8887ad04 /lib
parent1c7ebeabc9e5ee12e42075a597de40fdb9059530 (diff)
genwqe: Prevent an integer overflow in the ioctl
There are a couple potential integer overflows here. round_up(m->size + (m->addr & ~PAGE_MASK), PAGE_SIZE); The first thing is that the "m->size + (...)" addition could overflow, and the second is that round_up() overflows to zero if the result is within PAGE_SIZE of the type max. In this code, the "m->size" variable is an u64 but we're saving the result in "map_size" which is an unsigned long and genwqe_user_vmap() takes an unsigned long as well. So I have used ULONG_MAX as the upper bound. From a practical perspective unsigned long is fine/better than trying to change all the types to u64. Fixes: eaf4722d4645 ("GenWQE Character device and DDCB queue") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions