summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorGustavo A. R. Silva <gustavoars@kernel.org>2020-06-15 17:41:12 -0500
committerSteve French <stfrench@microsoft.com>2020-06-23 19:06:27 -0500
commitbf1028a41eaf0ce39518cbdda34cdb717f16364a (patch)
tree51048f8904b98eb8d54af4bcaf0469117405eec7 /lib
parent5618303d8516f8ac5ecfe53ee8e8bc9a40eaf066 (diff)
cifs: misc: Use array_size() in if-statement controlling expression
Use array_size() instead of the open-coded version in the controlling expression of the if statement. Also, while there, use the preferred form for passing a size of a struct. The alternative form where struct name is spelled out hurts readability and introduces an opportunity for a bug when the pointer variable type is changed but the corresponding sizeof that is passed as argument is not. This issue was found with the help of Coccinelle and, audited and fixed manually. Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com> Reviewed-by: Aurelien Aptel <aaptel@suse.com> Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions