diff options
| author | Simon Horman <horms@kernel.org> | 2024-07-31 10:15:28 +0100 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-08-01 09:03:52 -0700 |
| commit | 743ff02152bc46bb4a2f2a49ec891c87eba6ab5b (patch) | |
| tree | 7ddcce35b195f1073cc8f037ce40882812584c9c /net/ethtool/linkmodes.c | |
| parent | f9c141fc33393923451bdd190c67d9d4f5d2c67f (diff) | |
ethtool: Don't check for NULL info in prepare_data callbacks
Since commit f946270d05c2 ("ethtool: netlink: always pass genl_info to
.prepare_data") the info argument of prepare_data callbacks is never
NULL. Remove checks present in callback implementations.
Link: https://lore.kernel.org/netdev/20240703121237.3f8b9125@kernel.org/
Signed-off-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240731-prepare_data-null-check-v1-1-627f2320678f@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/ethtool/linkmodes.c')
| -rw-r--r-- | net/ethtool/linkmodes.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ethtool/linkmodes.c b/net/ethtool/linkmodes.c index b2591db49f7d..259cd9ef1f2a 100644 --- a/net/ethtool/linkmodes.c +++ b/net/ethtool/linkmodes.c @@ -40,7 +40,7 @@ static int linkmodes_prepare_data(const struct ethnl_req_info *req_base, return ret; ret = __ethtool_get_link_ksettings(dev, &data->ksettings); - if (ret < 0 && info) { + if (ret < 0) { GENL_SET_ERR_MSG(info, "failed to retrieve link settings"); goto out; } |