diff options
| author | Li Zetao <lizetao1@huawei.com> | 2024-08-22 12:32:47 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-08-23 14:27:45 +0100 |
| commit | 4c180887775f3e3fb46b9e447cf3ea539286919d (patch) | |
| tree | 4c4383c422611cd3352f119a36c1c772a581c521 /net/ipv4/fib_semantics.c | |
| parent | 2d522384fb5b8187cb7f8fe7d05c119ac38fd8f3 (diff) | |
ipv4: delete redundant judgment statements
The initial value of err is -ENOBUFS, and err is guaranteed to be
less than 0 before all goto errout. Therefore, on the error path
of errout, there is no need to repeatedly judge that err is less than 0,
and delete redundant judgments to make the code more concise.
Signed-off-by: Li Zetao <lizetao1@huawei.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/fib_semantics.c')
| -rw-r--r-- | net/ipv4/fib_semantics.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index 0f70341cb8b5..ba2df3d2ac15 100644 --- a/net/ipv4/fib_semantics.c +++ b/net/ipv4/fib_semantics.c @@ -543,8 +543,7 @@ void rtmsg_fib(int event, __be32 key, struct fib_alias *fa, info->nlh, GFP_KERNEL); return; errout: - if (err < 0) - rtnl_set_sk_err(info->nl_net, RTNLGRP_IPV4_ROUTE, err); + rtnl_set_sk_err(info->nl_net, RTNLGRP_IPV4_ROUTE, err); } static int fib_detect_death(struct fib_info *fi, int order, |