diff options
| author | françois romieu <romieu@fr.zoreil.com> | 2013-11-26 00:40:58 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-11-28 18:43:35 -0500 |
| commit | bc9627e7e918a85e906c1a3f6d01d9b8ef911a96 (patch) | |
| tree | fbc7e299b017b0ac3857fcb795bada64e57ca21e /net/ipv4/protocol.c | |
| parent | e63e60be62699e74c3e40711c50918b3c007db0a (diff) | |
via-velocity: fix netif_receive_skb use in irq disabled section.
2fdac010bdcf10a30711b6924612dfc40daf19b8 ("via-velocity.c: update napi
implementation") overlooked an irq disabling spinlock when the Rx part
of the NAPI poll handler was converted from netif_rx to netif_receive_skb.
NAPI Rx processing can be taken out of the locked section with a pair of
napi_{disable / enable} since it only races with the MTU change function.
An heavier rework of the NAPI locking would be able to perform NAPI Tx
before Rx where I simply removed one of velocity_tx_srv calls.
References: https://bugzilla.redhat.com/show_bug.cgi?id=1022733
Fixes: 2fdac010bdcf (via-velocity.c: update napi implementation)
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Tested-by: Alex A. Schmidt <aaschmidt1@gmail.com>
Cc: Jamie Heilman <jamie@audible.transient.net>
Cc: Michele Baldessari <michele@acksyn.org>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/protocol.c')
0 files changed, 0 insertions, 0 deletions