summaryrefslogtreecommitdiff
path: root/net/ipv4/raw_diag.c
diff options
context:
space:
mode:
authorCyrill Gorcunov <gorcunov@openvz.org>2016-11-02 15:36:31 +0300
committerDavid S. Miller <davem@davemloft.net>2016-11-03 15:25:26 -0400
commitcd05a0eca8752c63bf79c10ae1a877d36cca995a (patch)
tree49883c6d69c719f9e129b9f74d1a21ba995d39d9 /net/ipv4/raw_diag.c
parent17197236d62c44da127be461c63ac5cc2cce1e53 (diff)
net: ip, raw_diag -- Fix socket leaking for destroy request
In raw_diag_destroy the helper raw_sock_get returns with sock_hold call, so we have to put it then. CC: David S. Miller <davem@davemloft.net> CC: Eric Dumazet <eric.dumazet@gmail.com> CC: David Ahern <dsa@cumulusnetworks.com> CC: Andrey Vagin <avagin@openvz.org> CC: Stephen Hemminger <stephen@networkplumber.org> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> Acked-by: David Ahern <dsa@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/raw_diag.c')
-rw-r--r--net/ipv4/raw_diag.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/net/ipv4/raw_diag.c b/net/ipv4/raw_diag.c
index be930908bcf9..bf0b8842bf31 100644
--- a/net/ipv4/raw_diag.c
+++ b/net/ipv4/raw_diag.c
@@ -205,11 +205,14 @@ static int raw_diag_destroy(struct sk_buff *in_skb,
{
struct net *net = sock_net(in_skb->sk);
struct sock *sk;
+ int err;
sk = raw_sock_get(net, r);
if (IS_ERR(sk))
return PTR_ERR(sk);
- return sock_diag_destroy(sk, ECONNABORTED);
+ err = sock_diag_destroy(sk, ECONNABORTED);
+ sock_put(sk);
+ return err;
}
#endif