diff options
| author | Florian Westphal <fw@strlen.de> | 2023-10-26 16:45:42 +0200 |
|---|---|---|
| committer | Steffen Klassert <steffen.klassert@secunet.com> | 2023-10-27 10:12:09 +0200 |
| commit | eefed7662ff223f70ba8b1af07f1a096a5ece588 (patch) | |
| tree | 4699ec490e0ab0364feacc96a1723d4f38dea25e /net/ipv6 | |
| parent | 53a5b4f2ea858482a427878bca988a7fa9b2ebdc (diff) | |
xfrm: policy: fix layer 4 flowi decoding
The commit shipped with two bugs:
fl4->fl4_icmp_type = flkeys->icmp.type;
fl4->fl4_icmp_type = flkeys->icmp.code;
~~~~ should have been "code".
But the more severe bug is that I got fooled by flowi member defines:
fl4_icmp_type, fl4_gre_key and fl4_dport share the same union/address.
Fix typo and make gre/icmp key setting depend on the l4 protocol.
Fixes: 7a0207094f1b ("xfrm: policy: replace session decode with flow dissector")
Reported-and-tested-by: Antony Antony <antony@phenome.org>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Diffstat (limited to 'net/ipv6')
0 files changed, 0 insertions, 0 deletions