diff options
| author | Karthikeyan Periyasamy <quic_periyasa@quicinc.com> | 2023-02-06 21:33:30 +0530 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2023-02-14 12:35:02 +0100 |
| commit | aaacf1740f2f95e0c5449ff3bbcff252d69cf952 (patch) | |
| tree | ab1c00cef04faae38a3fce3790b2fc1c4a1590dc /net/mac80211/rx.c | |
| parent | 57b341e9ab13e5688491bfd54f8b5502416c8905 (diff) | |
wifi: mac80211: fix non-MLO station association
Non-MLO station frames are dropped in Rx path due to the condition
check in ieee80211_rx_is_valid_sta_link_id(). In multi-link AP scenario,
non-MLO stations try to connect in any of the valid links in the ML AP,
where the station valid_links and link_id params are valid in the
ieee80211_sta object. But ieee80211_rx_is_valid_sta_link_id() always
return false for the non-MLO stations by the assumption taken is
valid_links and link_id are not valid in non-MLO stations object
(ieee80211_sta), this assumption is wrong. Due to this assumption,
non-MLO station frames are dropped which leads to failure in association.
Fix it by removing the condition check and allow the link validation
check for the non-MLO stations.
Fixes: e66b7920aa5a ("wifi: mac80211: fix initialization of rx->link and rx->link_sta")
Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Link: https://lore.kernel.org/r/20230206160330.1613-1-quic_periyasa@quicinc.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/mac80211/rx.c')
| -rw-r--r-- | net/mac80211/rx.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index 759936aff2c3..dd571c715b8e 100644 --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c @@ -4094,9 +4094,6 @@ static void ieee80211_invoke_rx_handlers(struct ieee80211_rx_data *rx) static bool ieee80211_rx_is_valid_sta_link_id(struct ieee80211_sta *sta, u8 link_id) { - if (!sta->mlo) - return false; - return !!(sta->valid_links & BIT(link_id)); } |