summaryrefslogtreecommitdiff
path: root/net/netfilter/xt_sctp.c
diff options
context:
space:
mode:
authorWander Lairson Costa <wander@redhat.com>2023-08-28 19:12:55 -0300
committerPablo Neira Ayuso <pablo@netfilter.org>2023-08-30 17:34:01 +0200
commite99476497687ef9e850748fe6d232264f30bc8f9 (patch)
treeeafd37b4040d86c4a783de8fe2aaa11451afbb0c /net/netfilter/xt_sctp.c
parent28427f368f0e08d504ed06e74bc7cc79d6d06511 (diff)
netfilter: xt_sctp: validate the flag_info count
sctp_mt_check doesn't validate the flag_count field. An attacker can take advantage of that to trigger a OOB read and leak memory information. Add the field validation in the checkentry function. Fixes: 2e4e6a17af35 ("[NETFILTER] x_tables: Abstraction layer for {ip,ip6,arp}_tables") Cc: stable@vger.kernel.org Reported-by: Lucas Leong <wmliang@infosec.exchange> Signed-off-by: Wander Lairson Costa <wander@redhat.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/netfilter/xt_sctp.c')
-rw-r--r--net/netfilter/xt_sctp.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/netfilter/xt_sctp.c b/net/netfilter/xt_sctp.c
index e8961094a282..b46a6a512058 100644
--- a/net/netfilter/xt_sctp.c
+++ b/net/netfilter/xt_sctp.c
@@ -149,6 +149,8 @@ static int sctp_mt_check(const struct xt_mtchk_param *par)
{
const struct xt_sctp_info *info = par->matchinfo;
+ if (info->flag_count > ARRAY_SIZE(info->flag_info))
+ return -EINVAL;
if (info->flags & ~XT_SCTP_VALID_FLAGS)
return -EINVAL;
if (info->invflags & ~XT_SCTP_VALID_FLAGS)