diff options
author | Kai-Heng Feng <kai.heng.feng@canonical.com> | 2021-08-10 12:53:15 +0800 |
---|---|---|
committer | Marcel Holtmann <marcel@holtmann.org> | 2021-08-16 17:48:11 +0200 |
commit | 0ea53674d07fb6db2dd7a7ec2fdc85a12eb246c2 (patch) | |
tree | 4cd132da45450388ab58907cc4c1d352331cae87 /net/rxrpc/af_rxrpc.c | |
parent | 55981d3541812234e687062926ff199c83f79a39 (diff) |
Bluetooth: Move shutdown callback before flushing tx and rx queue
Commit 0ea9fd001a14 ("Bluetooth: Shutdown controller after workqueues
are flushed or cancelled") introduced a regression that makes mtkbtsdio
driver stops working:
[ 36.593956] Bluetooth: hci0: Firmware already downloaded
[ 46.814613] Bluetooth: hci0: Execution of wmt command timed out
[ 46.814619] Bluetooth: hci0: Failed to send wmt func ctrl (-110)
The shutdown callback depends on the result of hdev->rx_work, so we
should call it before flushing rx_work:
-> btmtksdio_shutdown()
-> mtk_hci_wmt_sync()
-> __hci_cmd_send()
-> wait for BTMTKSDIO_TX_WAIT_VND_EVT gets cleared
-> btmtksdio_recv_event()
-> hci_recv_frame()
-> queue_work(hdev->workqueue, &hdev->rx_work)
-> clears BTMTKSDIO_TX_WAIT_VND_EVT
So move the shutdown callback before flushing TX/RX queue to resolve the
issue.
Reported-and-tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Tested-by: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Fixes: 0ea9fd001a14 ("Bluetooth: Shutdown controller after workqueues are flushed or cancelled")
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Diffstat (limited to 'net/rxrpc/af_rxrpc.c')
0 files changed, 0 insertions, 0 deletions