diff options
| author | David Howells <dhowells@redhat.com> | 2022-12-19 15:32:32 +0000 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2023-01-06 09:43:32 +0000 |
| commit | d41b3f5b96881809c73f86e3ca436c9426610b7a (patch) | |
| tree | ce6a8bce0d039874a7d221def72b35e7f9ec4d12 /net/rxrpc/af_rxrpc.c | |
| parent | 0b9bb322f13d486d5b8630264ccbfb4794bb43a9 (diff) | |
rxrpc: Wrap accesses to get call state to put the barrier in one place
Wrap accesses to get the state of a call from outside of the I/O thread in
a single place so that the barrier needed to order wrt the error code and
abort code is in just that place.
Also use a barrier when setting the call state and again when reading the
call state such that the auxiliary completion info (error code, abort code)
can be read without taking a read lock on the call state lock.
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Diffstat (limited to 'net/rxrpc/af_rxrpc.c')
| -rw-r--r-- | net/rxrpc/af_rxrpc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c index f4e1ffff2ba4..61c30d0f6735 100644 --- a/net/rxrpc/af_rxrpc.c +++ b/net/rxrpc/af_rxrpc.c @@ -379,7 +379,7 @@ EXPORT_SYMBOL(rxrpc_kernel_end_call); bool rxrpc_kernel_check_life(const struct socket *sock, const struct rxrpc_call *call) { - return call->state != RXRPC_CALL_COMPLETE; + return !rxrpc_call_is_complete(call); } EXPORT_SYMBOL(rxrpc_kernel_check_life); |