diff options
author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2023-02-07 15:54:35 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2023-02-08 09:48:53 +0000 |
commit | 1f62879e36324d710dfd5ab92833fb1c51d8334a (patch) | |
tree | bfcbd394a0ca299c6976a251cbdbbe192c912def /net/sched/sch_taprio.c | |
parent | a1e6ad30fa193962b5aa61ea4d12ee83a7ce9020 (diff) |
net/sched: make stab available before ops->init() call
Some qdiscs like taprio turn out to be actually pretty reliant on a well
configured stab, to not underestimate the skb transmission time (by
properly accounting for L1 overhead).
In a future change, taprio will need the stab, if configured by the
user, to be available at ops->init() time. It will become even more
important in upcoming work, when the overhead will be used for the
queueMaxSDU calculation that is passed to an offloading driver.
However, rcu_assign_pointer(sch->stab, stab) is called right after
ops->init(), making it unavailable, and I don't really see a good reason
for that.
Move it earlier, which nicely seems to simplify the error handling path
as well.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_taprio.c')
0 files changed, 0 insertions, 0 deletions