summaryrefslogtreecommitdiff
path: root/net/smc
diff options
context:
space:
mode:
authorJohannes Berg <johannes.berg@intel.com>2021-05-17 16:13:35 +0200
committerDavid S. Miller <davem@davemloft.net>2021-05-17 15:24:20 -0700
commit35d96e631860226d5dc4de0fad0a415362ec2457 (patch)
tree56899f4180264f131f472da10e29dd0b331cf8f8 /net/smc
parent3c814519743a919f8b3c236c0565e24709806d66 (diff)
bonding: init notify_work earlier to avoid uninitialized use
If bond_kobj_init() or later kzalloc() in bond_alloc_slave() fail, then we call kobject_put() on the slave->kobj. This in turn calls the release function slave_kobj_release() which will always try to cancel_delayed_work_sync(&slave->notify_work), which shouldn't be done on an uninitialized work struct. Always initialize the work struct earlier to avoid problems here. Syzbot bisected this down to a completely pointless commit, some fault injection may have been at work here that caused the alloc failure in the first place, which may interact badly with bisect. Reported-by: syzbot+bfda097c12a00c8cae67@syzkaller.appspotmail.com Signed-off-by: Johannes Berg <johannes.berg@intel.com> Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/smc')
0 files changed, 0 insertions, 0 deletions