summaryrefslogtreecommitdiff
path: root/net/tipc
diff options
context:
space:
mode:
authorYueHaibing <yuehaibing@huawei.com>2022-11-19 15:28:32 +0800
committerJakub Kicinski <kuba@kernel.org>2022-11-21 20:50:24 -0800
commitcd0f6421162201e4b22ce757a1966729323185eb (patch)
treeda89b5d2b4c2a53621e6eae451b5e7a749173cea /net/tipc
parent5916380c313fe3e8603e7aae81ed358048c99ed9 (diff)
tipc: check skb_linearize() return value in tipc_disc_rcv()
If skb_linearize() fails in tipc_disc_rcv(), we need to free the skb instead of handle it. Fixes: 25b0b9c4e835 ("tipc: handle collisions of 32-bit node address hash values") Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Jon Maloy <jmaloy@redhat.com> Link: https://lore.kernel.org/r/20221119072832.7896-1-yuehaibing@huawei.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/tipc')
-rw-r--r--net/tipc/discover.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/net/tipc/discover.c b/net/tipc/discover.c
index e8630707901e..e8dcdf267c0c 100644
--- a/net/tipc/discover.c
+++ b/net/tipc/discover.c
@@ -211,7 +211,10 @@ void tipc_disc_rcv(struct net *net, struct sk_buff *skb,
u32 self;
int err;
- skb_linearize(skb);
+ if (skb_linearize(skb)) {
+ kfree_skb(skb);
+ return;
+ }
hdr = buf_msg(skb);
if (caps & TIPC_NODE_ID128)