summaryrefslogtreecommitdiff
path: root/net/wireless/wext-core.c
diff options
context:
space:
mode:
authorJouni Malinen <j@w1.fi>2020-01-07 17:35:45 +0200
committerJohannes Berg <johannes.berg@intel.com>2020-01-15 09:52:12 +0100
commit6f601265215a421f425ba3a4850a35861d024643 (patch)
tree693a07fc329a7e24148574d5525e955647b82db6 /net/wireless/wext-core.c
parent26ec17a1dc5ecdd8d91aba63ead6f8b5ad5dea0d (diff)
mac80211: Fix TKIP replay protection immediately after key setup
TKIP replay protection was skipped for the very first frame received after a new key is configured. While this is potentially needed to avoid dropping a frame in some cases, this does leave a window for replay attacks with group-addressed frames at the station side. Any earlier frame sent by the AP using the same key would be accepted as a valid frame and the internal RSC would then be updated to the TSC from that frame. This would allow multiple previously transmitted group-addressed frames to be replayed until the next valid new group-addressed frame from the AP is received by the station. Fix this by limiting the no-replay-protection exception to apply only for the case where TSC=0, i.e., when this is for the very first frame protected using the new key, and the local RSC had not been set to a higher value when configuring the key (which may happen with GTK). Signed-off-by: Jouni Malinen <j@w1.fi> Link: https://lore.kernel.org/r/20200107153545.10934-1-j@w1.fi Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/wireless/wext-core.c')
0 files changed, 0 insertions, 0 deletions