summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorAmerigo Wang <amwang@redhat.com>2013-02-07 15:52:40 +0000
committerDavid S. Miller <davem@davemloft.net>2013-02-08 17:55:48 -0500
commit6a98dcf032106eceb6827e0a7cc667250683f762 (patch)
tree1013315910d11d88ce380927cb32303062a0242d /net
parent14f8dc49532f765968ff37c3b99edbeb99004ace (diff)
ipv6: fix a RCU warning in net/ipv6/ip6_flowlabel.c
This patch fixes the following RCU warning: [ 51.680236] =============================== [ 51.681914] [ INFO: suspicious RCU usage. ] [ 51.683610] 3.8.0-rc6-next-20130206-sasha-00028-g83214f7-dirty #276 Tainted: G W [ 51.686703] ------------------------------- [ 51.688281] net/ipv6/ip6_flowlabel.c:671 suspicious rcu_dereference_check() usage! we should use rcu_dereference_bh() when we hold rcu_read_lock_bh(). Reported-by: Sasha Levin <sasha.levin@oracle.com> Cc: David S. Miller <davem@davemloft.net> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Signed-off-by: Cong Wang <amwang@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv6/ip6_flowlabel.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/net/ipv6/ip6_flowlabel.c b/net/ipv6/ip6_flowlabel.c
index ea42bf40a997..a7da2f472479 100644
--- a/net/ipv6/ip6_flowlabel.c
+++ b/net/ipv6/ip6_flowlabel.c
@@ -65,13 +65,13 @@ static DEFINE_SPINLOCK(ip6_fl_lock);
static DEFINE_SPINLOCK(ip6_sk_fl_lock);
#define for_each_fl_rcu(hash, fl) \
- for (fl = rcu_dereference(fl_ht[(hash)]); \
+ for (fl = rcu_dereference_bh(fl_ht[(hash)]); \
fl != NULL; \
- fl = rcu_dereference(fl->next))
+ fl = rcu_dereference_bh(fl->next))
#define for_each_fl_continue_rcu(fl) \
- for (fl = rcu_dereference(fl->next); \
+ for (fl = rcu_dereference_bh(fl->next); \
fl != NULL; \
- fl = rcu_dereference(fl->next))
+ fl = rcu_dereference_bh(fl->next))
#define for_each_sk_fl_rcu(np, sfl) \
for (sfl = rcu_dereference_bh(np->ipv6_fl_list); \