summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorEric Biggers <ebiggers@google.com>2019-06-10 13:02:19 -0700
committerJohannes Berg <johannes.berg@intel.com>2019-06-14 15:46:33 +0200
commit4f488fbca2a86cc7714a128952eead92cac279ab (patch)
tree247e1fe0b71831ee8aceb3af923bc7d49126bb53 /net
parent1a473d6092d5d182914bea854ce0b21e6d12519d (diff)
cfg80211: fix memory leak of wiphy device name
In wiphy_new_nm(), if an error occurs after dev_set_name() and device_initialize() have already been called, it's necessary to call put_device() (via wiphy_free()) to avoid a memory leak. Reported-by: syzbot+7fddca22578bc67c3fe4@syzkaller.appspotmail.com Fixes: 1f87f7d3a3b4 ("cfg80211: add rfkill support") Cc: stable@vger.kernel.org Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net')
-rw-r--r--net/wireless/core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/wireless/core.c b/net/wireless/core.c
index 4e83892f1ac2..c58acca09301 100644
--- a/net/wireless/core.c
+++ b/net/wireless/core.c
@@ -513,7 +513,7 @@ use_default_name:
&rdev->rfkill_ops, rdev);
if (!rdev->rfkill) {
- kfree(rdev);
+ wiphy_free(&rdev->wiphy);
return NULL;
}