summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@redhat.com>2015-07-08 21:42:11 +0200
committerDavid S. Miller <davem@davemloft.net>2015-07-09 15:05:32 -0700
commitfecdf8be2d91e04b0a9a4f79ff06499a36f5d14f (patch)
tree32cd5f2438ccdf55752a090cd86f3443e2c78ee7 /net
parent4a0e3e989d66bb7204b163d9cfaa7fa96d0f2023 (diff)
net: pktgen: fix race between pktgen_thread_worker() and kthread_stop()
pktgen_thread_worker() is obviously racy, kthread_stop() can come between the kthread_should_stop() check and set_current_state(). Signed-off-by: Oleg Nesterov <oleg@redhat.com> Reported-by: Jan Stancek <jstancek@redhat.com> Reported-by: Marcelo Leitner <mleitner@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/core/pktgen.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 05badbb58865..41489e3c69af 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3572,8 +3572,10 @@ static int pktgen_thread_worker(void *arg)
pktgen_rem_thread(t);
/* Wait for kthread_stop */
- while (!kthread_should_stop()) {
+ for (;;) {
set_current_state(TASK_INTERRUPTIBLE);
+ if (kthread_should_stop())
+ break;
schedule();
}
__set_current_state(TASK_RUNNING);