summaryrefslogtreecommitdiff
path: root/samples/bpf
diff options
context:
space:
mode:
authorPengcheng Yang <yangpc@wangsu.com>2023-05-05 16:50:58 +0800
committerAlexei Starovoitov <ast@kernel.org>2023-05-05 08:37:48 -0700
commitf4dea9689c5fea3d07170c2cb0703e216f1a0922 (patch)
tree34a7d7597ca3580c2ddb981f1ec3d3bc87405bbd /samples/bpf
parent69535186297b37e6e0a16290766666f4e8a55793 (diff)
samples/bpf: Fix buffer overflow in tcp_basertt
Using sizeof(nv) or strlen(nv)+1 is correct. Fixes: c890063e4404 ("bpf: sample BPF_SOCKET_OPS_BASE_RTT program") Signed-off-by: Pengcheng Yang <yangpc@wangsu.com> Link: https://lore.kernel.org/r/1683276658-2860-1-git-send-email-yangpc@wangsu.com Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'samples/bpf')
-rw-r--r--samples/bpf/tcp_basertt_kern.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/samples/bpf/tcp_basertt_kern.c b/samples/bpf/tcp_basertt_kern.c
index 8dfe09a92fec..822b0742b815 100644
--- a/samples/bpf/tcp_basertt_kern.c
+++ b/samples/bpf/tcp_basertt_kern.c
@@ -47,7 +47,7 @@ int bpf_basertt(struct bpf_sock_ops *skops)
case BPF_SOCK_OPS_BASE_RTT:
n = bpf_getsockopt(skops, SOL_TCP, TCP_CONGESTION,
cong, sizeof(cong));
- if (!n && !__builtin_memcmp(cong, nv, sizeof(nv)+1)) {
+ if (!n && !__builtin_memcmp(cong, nv, sizeof(nv))) {
/* Set base_rtt to 80us */
rv = 80;
} else if (n) {