summaryrefslogtreecommitdiff
path: root/scripts/genksyms
diff options
context:
space:
mode:
authorMasahiro Yamada <masahiroy@kernel.org>2025-01-14 00:00:50 +0900
committerMasahiro Yamada <masahiroy@kernel.org>2025-01-18 09:11:46 +0900
commita8b7d066f8626ec847d3e66aef1320968d1fe298 (patch)
tree085d4d87aea414c4e7acda9171419aa5bd10e94f /scripts/genksyms
parent2966b66c94a2b0d897f8626b8f2c50a0fd4878a9 (diff)
genksyms: fix syntax error for attribute before nested_declarator
A longstanding issue with genksyms is that it has hidden syntax errors. When a syntax error occurs, yyerror() is called. However, error_with_pos() is a no-op unless the -w option is provided. You can observe syntax errors by manually passing the -w option. For example, with CONFIG_MODVERSIONS=y on v6.13-rc1: $ make -s KCFLAGS=-D__GENKSYMS__ drivers/acpi/prmt.i $ cat drivers/acpi/prmt.i | scripts/genksyms/genksyms -w [ snip ] drivers/acpi/prmt.c:56: syntax error The syntax error occurs in the following code in drivers/acpi/prmt.c: struct prm_handler_info { [ snip ] efi_status_t (__efiapi *handler_addr)(u64, void *); [ snip ] }; The issue arises from __efiapi, which is defined as either __attribute__((ms_abi)) or __attribute__((regparm(0))). This commit allows nested_declarator to be prefixed with attributes. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Acked-by: Nicolas Schier <n.schier@avm.de>
Diffstat (limited to 'scripts/genksyms')
-rw-r--r--scripts/genksyms/parse.y4
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/genksyms/parse.y b/scripts/genksyms/parse.y
index 54e16c2e0b4b..49d3e536b9a8 100644
--- a/scripts/genksyms/parse.y
+++ b/scripts/genksyms/parse.y
@@ -345,8 +345,8 @@ direct_nested_declarator1:
{ $$ = $4; }
| direct_nested_declarator1 BRACKET_PHRASE
{ $$ = $2; }
- | '(' nested_declarator ')'
- { $$ = $3; }
+ | '(' attribute_opt nested_declarator ')'
+ { $$ = $4; }
| '(' error ')'
{ $$ = $3; }
;