summaryrefslogtreecommitdiff
path: root/scripts/kconfig/nconf.c
diff options
context:
space:
mode:
authorMasahiro Yamada <yamada.masahiro@socionext.com>2019-05-10 15:12:04 +0900
committerMasahiro Yamada <yamada.masahiro@socionext.com>2019-05-11 02:14:27 +0900
commitceb7f3296ea1fa652d68e5ecb0facf5fba19a554 (patch)
tree7b7bbbb1e9eb33a74f6221c433f7fc6e5c0309a6 /scripts/kconfig/nconf.c
parent65be755a54117fc02134c288e41e8d3d5e586c4e (diff)
kconfig: do not accept a directory for configuration output
Currently, conf_write() can be called with a directory name instead of a file name. As far as I see, this can happen for menuconfig, nconfig, gconfig. If it is given with a directory path, conf_write() kindly appends getenv("KCONFIG_CONFIG"), but this ends up with hacky dir/basename handling, and screwed up in corner-cases like "what if KCONFIG_CONFIG is an absolute path?" as discussed before: https://patchwork.kernel.org/patch/9910037/ Since conf_write() is already messed up, I'd say "do not do it". Please pass a file path all the time. If a directory path is specified for the configuration output, conf_write() will simply error out. Now that the tmp file is created in the same directory as the .config, the previously reported "what if KCONFIG_CONFIG points to a different file system?" has been solved. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Cc: Nicolas Porcel <nicolasporcel06@gmail.com>
Diffstat (limited to 'scripts/kconfig/nconf.c')
0 files changed, 0 insertions, 0 deletions