summaryrefslogtreecommitdiff
path: root/security/selinux
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2020-08-19 11:42:56 +0100
committerPaul Moore <paul@paul-moore.com>2020-08-19 09:14:04 -0400
commit69ea651c40f7f08962d440a0486fd0212be74b73 (patch)
tree1193a2717426983f4d656d49245a61c6e7a1d728 /security/selinux
parentc7c556f1e81bb9e09656ed6650d0c44c84b7c016 (diff)
selinux: fix allocation failure check on newpolicy->sidtab
The allocation check of newpolicy->sidtab is null checking if newpolicy is null and not newpolicy->sidtab. Fix this. Addresses-Coverity: ("Logically dead code") Fixes: c7c556f1e81b ("selinux: refactor changing booleans") Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com> Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'security/selinux')
-rw-r--r--security/selinux/ss/services.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index f6f78c65f53f..d310910fb639 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -2224,7 +2224,7 @@ int security_load_policy(struct selinux_state *state, void *data, size_t len,
return -ENOMEM;
newpolicy->sidtab = kzalloc(sizeof(*newpolicy->sidtab), GFP_KERNEL);
- if (!newpolicy)
+ if (!newpolicy->sidtab)
goto err;
rc = policydb_read(&newpolicy->policydb, fp);