summaryrefslogtreecommitdiff
path: root/tools/lib
diff options
context:
space:
mode:
authorChenyuan Mi <cymi20@fudan.edu.cn>2023-06-14 08:01:18 -0700
committerNamhyung Kim <namhyung@kernel.org>2023-06-20 16:55:35 -0700
commit53fc25b7f557089aff101235152ae4bff15c428a (patch)
tree864cba4e08d999ce2895599c9238ef0bdf05f9db /tools/lib
parent240de691dd6684d15f63613aa7fbc64e6098d6c9 (diff)
perf subcmd: Fix missing check for return value of malloc() in add_cmdname()
The malloc() function may return NULL when it fails, which may cause null pointer deference in add_cmdname(), add Null check for return value of malloc(). Found by our static analysis tool. Signed-off-by: Chenyuan Mi <cymi20@fudan.edu.cn> Acked-by: Ian Rogers <irogers@google.com> Cc: Leo Yan <leo.yan@linaro.org> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: linux-kernel@vger.kernel.org Link: https://lore.kernel.org/r/20230614150118.115208-1-cymi20@fudan.edu.cn Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools/lib')
-rw-r--r--tools/lib/subcmd/help.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/tools/lib/subcmd/help.c b/tools/lib/subcmd/help.c
index a66fb1a1a312..67a8d6b740ea 100644
--- a/tools/lib/subcmd/help.c
+++ b/tools/lib/subcmd/help.c
@@ -16,6 +16,8 @@
void add_cmdname(struct cmdnames *cmds, const char *name, size_t len)
{
struct cmdname *ent = malloc(sizeof(*ent) + len + 1);
+ if (!ent)
+ return;
ent->len = len;
memcpy(ent->name, name, len);