summaryrefslogtreecommitdiff
path: root/tools/pci
diff options
context:
space:
mode:
authorAlan Mikhak <alan.mikhak@sifive.com>2019-05-23 14:18:00 -0700
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>2019-05-29 17:44:09 +0100
commit8a5e0af240e07dd3d4897eb8ff52aab757da7fab (patch)
tree60d9fa1676ece7d9ef12f7556e8e01bebad9b1aa /tools/pci
parenta188339ca5a396acc588e5851ed7e19f66b0ebd9 (diff)
tools: PCI: Fix broken pcitest compilation
pcitest is currently broken due to the following compiler error and related warning. Fix by changing the run_test() function signature to return an integer result. pcitest.c: In function run_test: pcitest.c:143:9: warning: return with a value, in function returning void return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */ pcitest.c: In function main: pcitest.c:232:9: error: void value not ignored as it ought to be return run_test(test); Fixes: fef31ecaaf2c ("tools: PCI: Fix compilation warnings") Signed-off-by: Alan Mikhak <alan.mikhak@sifive.com> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>
Diffstat (limited to 'tools/pci')
-rw-r--r--tools/pci/pcitest.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
index 5fa5c2bdd427..6dce894667f6 100644
--- a/tools/pci/pcitest.c
+++ b/tools/pci/pcitest.c
@@ -47,15 +47,15 @@ struct pci_test {
unsigned long size;
};
-static void run_test(struct pci_test *test)
+static int run_test(struct pci_test *test)
{
- long ret;
+ int ret = -EINVAL;
int fd;
fd = open(test->device, O_RDWR);
if (fd < 0) {
perror("can't open PCI Endpoint Test device");
- return;
+ return -ENODEV;
}
if (test->barnum >= 0 && test->barnum <= 5) {