summaryrefslogtreecommitdiff
path: root/tools/testing
diff options
context:
space:
mode:
authorIgnat Korchagin <ignat@cloudflare.com>2024-03-13 19:37:58 +0100
committerDavid S. Miller <davem@davemloft.net>2024-03-18 12:25:52 +0000
commitd7db7775ea2e31502d46427f5efd385afc4ff1eb (patch)
treea966e7c6cbca1c90b14aa7009b93b7f09d0f830f /tools/testing
parent6ebfad33161afacb3e1e59ed1c2feefef70f9f97 (diff)
net: veth: do not manipulate GRO when using XDP
Commit d3256efd8e8b ("veth: allow enabling NAPI even without XDP") tried to fix the fact that GRO was not possible without XDP, because veth did not use NAPI without XDP. However, it also introduced the behaviour that GRO is always enabled, when XDP is enabled. While it might be desired for most cases, it is confusing for the user at best as the GRO flag suddenly changes, when an XDP program is attached. It also introduces some complexities in state management as was partially addressed in commit fe9f801355f0 ("net: veth: clear GRO when clearing XDP even when down"). But the biggest problem is that it is not possible to disable GRO at all, when an XDP program is attached, which might be needed for some use cases. Fix this by not touching the GRO flag on XDP enable/disable as the code already supports switching to NAPI if either GRO or XDP is requested. Link: https://lore.kernel.org/lkml/20240311124015.38106-1-ignat@cloudflare.com/ Fixes: d3256efd8e8b ("veth: allow enabling NAPI even without XDP") Fixes: fe9f801355f0 ("net: veth: clear GRO when clearing XDP even when down") Signed-off-by: Ignat Korchagin <ignat@cloudflare.com> Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/testing')
0 files changed, 0 insertions, 0 deletions