summaryrefslogtreecommitdiff
path: root/tools/testing
diff options
context:
space:
mode:
authorHangbin Liu <liuhangbin@gmail.com>2023-10-31 11:47:32 +0800
committerDavid S. Miller <davem@davemloft.net>2023-11-03 09:15:42 +0000
commit63e201916b27260218e528a2f8758be47f99bbf4 (patch)
tree2db6fd87978fa3478282d8964eb701ed9fdf1ba0 /tools/testing
parentdb456d90a4c1b43b6251fa4348c8adc59b583274 (diff)
selftests: pmtu.sh: fix result checking
In the PMTU test, when all previous tests are skipped and the new test passes, the exit code is set to 0. However, the current check mistakenly treats this as an assignment, causing the check to pass every time. Consequently, regardless of how many tests have failed, if the latest test passes, the PMTU test will report a pass. Fixes: 2a9d3716b810 ("selftests: pmtu.sh: improve the test result processing") Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> Acked-by: Po-Hsu Lin <po-hsu.lin@canonical.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/testing')
-rwxr-xr-xtools/testing/selftests/net/pmtu.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh
index f838dd370f6a..b3b2dc5a630c 100755
--- a/tools/testing/selftests/net/pmtu.sh
+++ b/tools/testing/selftests/net/pmtu.sh
@@ -2048,7 +2048,7 @@ run_test() {
case $ret in
0)
all_skipped=false
- [ $exitcode=$ksft_skip ] && exitcode=0
+ [ $exitcode -eq $ksft_skip ] && exitcode=0
;;
$ksft_skip)
[ $all_skipped = true ] && exitcode=$ksft_skip