summaryrefslogtreecommitdiff
path: root/drivers/net/wireless/iwlegacy/3945.c
AgeCommit message (Collapse)Author
2012-11-26iwlegacy: initialize rx_statusJohannes Berg
The vendor radiotap patch added a few fields to struct ieee80211_rx_status that need to be zero, initialize the struct instead of using whatever was left on the stack. Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-05-10drivers/net: Convert compare_ether_addr to ether_addr_equalJoe Perches
Use the new bool function ether_addr_equal to add some clarity and reduce the likelihood for misuse of compare_ether_addr for sorting. Done via cocci script: $ cat compare_ether_addr.cocci @@ expression a,b; @@ - !compare_ether_addr(a, b) + ether_addr_equal(a, b) @@ expression a,b; @@ - compare_ether_addr(a, b) + !ether_addr_equal(a, b) @@ expression a,b; @@ - !ether_addr_equal(a, b) == 0 + ether_addr_equal(a, b) @@ expression a,b; @@ - !ether_addr_equal(a, b) != 0 + !ether_addr_equal(a, b) @@ expression a,b; @@ - ether_addr_equal(a, b) == 0 + !ether_addr_equal(a, b) @@ expression a,b; @@ - ether_addr_equal(a, b) != 0 + ether_addr_equal(a, b) @@ expression a,b; @@ - !!ether_addr_equal(a, b) + ether_addr_equal(a, b) Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2012-03-25net: add a truesize parameter to skb_add_rx_frag()Eric Dumazet
skb_add_rx_frag() API is misleading. Network skbs built with this helper can use uncharged kernel memory and eventually stress/crash machine in OOM. Add a 'truesize' parameter and then fix drivers in followup patches. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2012-03-18Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/netDavid S. Miller
2012-03-12iwl3945: fix possible il->txq NULL pointer dereference in delayed worksStanislaw Gruszka
On il3945_down procedure we free tx queue data and nullify il->txq pointer. After that we drop mutex and then cancel delayed works. There is possibility, that after drooping mutex and before the cancel, some delayed work will start and crash while trying to send commands to the device. For example, here is reported crash in il3945_bg_reg_txpower_periodic(): https://bugzilla.kernel.org/show_bug.cgi?id=42766#c10 Patch fix problem by adding il->txq check on works that send commands, hence utilize tx queue. Reported-by: Clemens Eisserer <linuxhippy@gmail.com> Cc: stable@vger.kernel.org Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-22iwlegacy: s/il_txq_mem/il_free_txq_mem/gStanislaw Gruszka
Previous name was confusing. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-22iwlegacy: small queue initializations cleanupStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-22iwlegacy: do not grab nic access if rfkillStanislaw Gruszka
If rfkill is on il_grab_nic_access() fail and we can not write to the various registers during stop procedure. Write to those registers unconditionally instead. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-22iwlegacy: get rid of tx/rx traffic logStanislaw Gruszka
The same data can be gathered using monitor mode. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-22iwlegacy: merge all ops structures into oneStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-22iwlegacy: merge il_lib_ops into il_opsStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-22iwlegacy: remove il_apm_opsStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-22iwlegacy: merge eeprom_ops into lib_opsStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-22iwlegacy: move debugfs_ops to il_privStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-22iwlegacy: regulatory_bands is not an opsStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-06iwlegacy: remove struct il_tx_infoStanislaw Gruszka
It's just wrapper to sk_buff pointers ... Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-06iwlegacy: merge il_base_params into il_cfgStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-06iwlegacy: move ops out of configStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-06iwlegacy: get rid of ctx structureStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-06iwlegacy: move bcast_sta_id to hw_paramsStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-02-06iwlegacy: move rxon commands out of ctx structureStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-01-04iwlegacy: 3945: simplify calculations of retry limitStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-01-04iwlegacy: 3945: get rid of hw_{set,get}_rateStanislaw Gruszka
Remove these helpers, some are not unused at all, one can be unrolled in place of use. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2012-01-04iwlegacy: off by one in iwl3945_hw_build_tx_cmd_rate()Dan Carpenter
We use "rate_index" like this: rate = iwl3945_rates[rate_index].plcp; The iwl3945_rates[] array has IWL_RATE_COUNT_3945 elements so the limit here is off by one. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: John W. Linville <linville@tuxdriver.com>
2011-11-16iwlegacy: debugfs_ops should depend on CONFIG_IWLEGACY_DEBUGFSGreg Dietsche
Only setup structs related to debugfs_ops when CONFIG_IWLEGACY_DEBUGFS is set. Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: checkpatch.pl fixesStanislaw Gruszka
Fix most checkpatch.pl ERRORs and some WARNINGs. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: indentions and whitespacesStanislaw Gruszka
Process iwlegacy source files using: indent -npro -l500 -nhnl indent -npro -kr -i8 -ts8 -sob -l80 -nbbo -ss -ncs -cp1 -il0 -psl Plus manual compilation fixes. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: merge iwl-{eeprom,led}.h into common.hStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: merge common header filesStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: rename iwl-core.h to common.hStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: rename iwl-commands.h to commands.hStanislaw Gruszka
On the way remove also not needed iwl-fh.h include. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: rename other handlersStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: s/rx_reply/hdl/Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: s/rx_handler/handler/Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: rename REPLY_ to N_ or C_Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: s/STATISTICS/STATS/Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: s/STATUS_/S_/Stanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: move iwl-3945-{,hw,fh,debugfs}.h to 3945.hStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: merge iwl-3945-led.c into 3945.cStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
2011-11-15iwlegacy: rename base 4965 and 3945 file namesStanislaw Gruszka
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>