From 27d231c0c63bb619997a24bab85d54d90ca71110 Mon Sep 17 00:00:00 2001 From: Trond Myklebust Date: Sat, 11 Apr 2020 11:37:18 -0400 Subject: pNFS: Fix RCU lock leakage Another brown paper bag moment. pnfs_alloc_ds_commits_list() is leaking the RCU lock. Fixes: a9901899b649 ("pNFS: Add infrastructure for cleaning up per-layout commit structures") Signed-off-by: Trond Myklebust --- fs/nfs/pnfs_nfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nfs/pnfs_nfs.c b/fs/nfs/pnfs_nfs.c index 25f135572fc8..e7ddbce48321 100644 --- a/fs/nfs/pnfs_nfs.c +++ b/fs/nfs/pnfs_nfs.c @@ -501,6 +501,7 @@ pnfs_alloc_ds_commits_list(struct list_head *list, rcu_read_lock(); pnfs_put_commit_array(array, cinfo->inode); } + rcu_read_unlock(); return ret; } -- cgit