From a2d05fb73493ca89b36c7d2c3ffc76effbfcd763 Mon Sep 17 00:00:00 2001 From: Yang Yingliang Date: Tue, 21 Dec 2021 19:38:25 +0800 Subject: gpio: sim: add missing fwnode_handle_put() in gpio_sim_probe() Calling fwnode_handle_put() when break out of device_for_each_child_node(), or the device node reference will be leakd. Fixes: 83960fcf4818 ("gpio: sim: new testing module") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-sim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'drivers/gpio') diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c index bef00dcc4dc8..838bbfed11d3 100644 --- a/drivers/gpio/gpio-sim.c +++ b/drivers/gpio/gpio-sim.c @@ -444,8 +444,10 @@ static int gpio_sim_probe(struct platform_device *pdev) device_for_each_child_node(dev, swnode) { ret = gpio_sim_add_bank(swnode, dev); - if (ret) + if (ret) { + fwnode_handle_put(swnode); return ret; + } } return 0; -- cgit