From 7b55033fbed07bad695ba744db3070c1cc351dc4 Mon Sep 17 00:00:00 2001 From: "Gustavo A. R. Silva" Date: Wed, 24 May 2017 04:18:52 -0500 Subject: mfd: wm831x-spi: Add NULL check before pointer dereference Add NULL check before dereferencing pointer of_id in order to avoid a potential NULL pointer dereference. Addresses-Coverity-ID: 1408830 Signed-off-by: Gustavo A. R. Silva Signed-off-by: Lee Jones --- drivers/mfd/wm831x-spi.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'drivers/mfd/wm831x-spi.c') diff --git a/drivers/mfd/wm831x-spi.c b/drivers/mfd/wm831x-spi.c index c332e2885b26..018ce652ae57 100644 --- a/drivers/mfd/wm831x-spi.c +++ b/drivers/mfd/wm831x-spi.c @@ -34,6 +34,10 @@ static int wm831x_spi_probe(struct spi_device *spi) if (spi->dev.of_node) { of_id = of_match_device(wm831x_of_match, &spi->dev); + if (!of_id) { + dev_err(&spi->dev, "Failed to match device\n"); + return -ENODEV; + } type = (enum wm831x_parent)of_id->data; } else { type = (enum wm831x_parent)id->driver_data; -- cgit