From 7eec67869893bc34bd3a3126e5124a4ef017e0cd Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Mon, 13 Jan 2020 15:59:33 +0300 Subject: regulator: mpq7920: Check the correct variable in mpq7920_regulator_register() There is a typo in the error checking. We should be checking "->rdev[i]" instead of just "->rdev". Fixes: 6501c1f54a17 ("regulator: mpq7920: add mpq7920 regulator driver") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20200113125805.xri6jqoxy2ldzqyg@kili.mountain Signed-off-by: Mark Brown --- drivers/regulator/mpq7920.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/regulator') diff --git a/drivers/regulator/mpq7920.c b/drivers/regulator/mpq7920.c index ab1b847c57e5..80f3131f0d1b 100644 --- a/drivers/regulator/mpq7920.c +++ b/drivers/regulator/mpq7920.c @@ -274,8 +274,8 @@ static inline int mpq7920_regulator_register( info->rdev[i] = devm_regulator_register(info->dev, rdesc, config); - if (IS_ERR(info->rdev)) - return PTR_ERR(info->rdev); + if (IS_ERR(info->rdev[i])) + return PTR_ERR(info->rdev[i]); } return 0; -- cgit