From 31301dd46975b2423fd38fc64bc58728d89dbcac Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Tue, 9 Aug 2022 13:47:03 -0400 Subject: bcachefs: Fix missing error handling in bch2_subvolume_delete() This fixes an assertion when the transaction has been unexpectedly restarted. Signed-off-by: Kent Overstreet --- fs/bcachefs/subvolume.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'fs/bcachefs') diff --git a/fs/bcachefs/subvolume.c b/fs/bcachefs/subvolume.c index b5b0f5e39f97..24244bc3d2fb 100644 --- a/fs/bcachefs/subvolume.c +++ b/fs/bcachefs/subvolume.c @@ -877,6 +877,8 @@ int bch2_subvolume_delete(struct btree_trans *trans, u32 subvolid) goto err; ret = bch2_snapshot_node_set_deleted(trans, snapid); + if (ret) + goto err; h = bch2_trans_kmalloc(trans, sizeof(*h)); ret = PTR_ERR_OR_ZERO(h); -- cgit