From 48ffdab1c1eb87fee9ed7366472e2b9aa4577a60 Mon Sep 17 00:00:00 2001 From: BoxiLiu Date: Wed, 30 Oct 2013 08:07:20 -0400 Subject: ext4: change ext4_read_inline_dir() to return 0 on success In ext4_read_inline_dir(), if there is inline data, the successful return value is the return value of ext4_read_inline_data(). Howewer, this is used by ext4_readdir(), and while it seems harmless to return a positive value on success, it's inconsistent, since historically we've always return 0 on success. Signed-off-by: BoxiLiu Signed-off-by: "Theodore Ts'o" Acked-by: Tao Ma --- fs/ext4/inline.c | 1 + 1 file changed, 1 insertion(+) (limited to 'fs/ext4/inline.c') diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c index d9ecbf1113a7..c3efb65d2ec6 100644 --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -1442,6 +1442,7 @@ int ext4_read_inline_dir(struct file *file, if (ret < 0) goto out; + ret = 0; sb = inode->i_sb; parent_ino = le32_to_cpu(((struct ext4_dir_entry_2 *)dir_buf)->inode); offset = ctx->pos; -- cgit