From 3b224e1df650df22541724c4bd5f1622b40d4ba4 Mon Sep 17 00:00:00 2001 From: Christian Brauner Date: Tue, 17 Oct 2023 20:48:23 +0200 Subject: fs: assert that open_mutex isn't held over holder ops With recent block level changes we should never be in a situation where we hold disk->open_mutex when calling into these helpers. So assert that in the code. Signed-off-by: Christoph Hellwig Link: https://lore.kernel.org/r/20231017184823.1383356-6-hch@lst.de Reviewed-by: Ming Lei Reviewed-by: Jan Kara Reviewed-by: Jens Axboe Signed-off-by: Christian Brauner --- fs/super.c | 1 + 1 file changed, 1 insertion(+) (limited to 'fs/super.c') diff --git a/fs/super.c b/fs/super.c index 799b8db1931e..c7b452e12e4c 100644 --- a/fs/super.c +++ b/fs/super.c @@ -1433,6 +1433,7 @@ static struct super_block *bdev_super_lock_shared(struct block_device *bdev) lockdep_assert_held(&bdev->bd_holder_lock); lockdep_assert_not_held(&sb->s_umount); + lockdep_assert_not_held(&bdev->bd_disk->open_mutex); /* Make sure sb doesn't go away from under us */ spin_lock(&sb_lock); -- cgit