From 2306a67745ebdf3f98bc954248b74a3f1d57cdc2 Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Fri, 2 Mar 2018 08:42:59 +1100 Subject: leaking_addresses: explicitly name variable used in regex Currently sub routine may_leak_address() is checking regex against Perl special variable $_ which is _fortunately_ being set correctly in a loop before this sub routine is called. We already have declared a variable to hold this value '$line' we should use it. Use $line in regex match instead of implicit $_ Signed-off-by: Tobin C. Harding --- scripts/leaking_addresses.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'scripts/leaking_addresses.pl') diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl index ce3b9d5a5bbc..ba5f9709bced 100755 --- a/scripts/leaking_addresses.pl +++ b/scripts/leaking_addresses.pl @@ -363,7 +363,7 @@ sub may_leak_address } $address_re = get_address_re(); - while (/($address_re)/g) { + while ($line =~ /($address_re)/g) { if (!is_false_positive($1)) { return 1; } -- cgit