summaryrefslogtreecommitdiff
path: root/drivers/hwmon/max6621.c
diff options
context:
space:
mode:
authorDarrick J. Wong <djwong@kernel.org>2024-01-29 20:27:23 -0800
committerChandan Babu R <chandanbabu@kernel.org>2024-01-30 14:04:43 +0530
commit881f78f472556ed05588172d5b5676b48dc48240 (patch)
tree9f48f80ac47f54ddc730a3cdc9e427589997edbe /drivers/hwmon/max6621.c
parent82ef1a5356572219f41f9123ca047259a77bd67b (diff)
xfs: remove conditional building of rt geometry validator functions
I mistakenly turned off CONFIG_XFS_RT in the Kconfig file for arm64 variant of the djwong-wtf git branch. Unfortunately, it took me a good hour to figure out that RT wasn't built because this is what got printed to dmesg: XFS (sda2): realtime geometry sanity check failed XFS (sda2): Metadata corruption detected at xfs_sb_read_verify+0x170/0x190 [xfs], xfs_sb block 0x0 Whereas I would have expected: XFS (sda2): Not built with CONFIG_XFS_RT XFS (sda2): RT mount failed The root cause of these problems is the conditional compilation of the new functions xfs_validate_rtextents and xfs_compute_rextslog that I introduced in the two commits listed below. The !RT versions of these functions return false and 0, respectively, which causes primary superblock validation to fail, which explains the first message. Move the two functions to other parts of libxfs that are not conditionally defined by CONFIG_XFS_RT and remove the broken stubs so that validation works again. Fixes: e14293803f4e ("xfs: don't allow overly small or large realtime volumes") Fixes: a6a38f309afc ("xfs: make rextslog computation consistent with mkfs") Signed-off-by: "Darrick J. Wong" <djwong@kernel.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
Diffstat (limited to 'drivers/hwmon/max6621.c')
0 files changed, 0 insertions, 0 deletions